adriangb opened a new pull request, #27087: URL: https://github.com/apache/datafusion/pull/27087
## Which issue does this PR close? - This PR does not close an issue. It is related to https://github.com/apache/datafusion/issues/21625 and follows up on https://github.com/apache/datafusion/pull/21666. ## Rationale for this change The partitioned hash join dynamic filter coordinator marks a partition as "canceled" when its stream is dropped before it reports its build data. A reader can assume that this means the whole query was canceled. That assumption is wrong. A parent operator can legally finish early and drop one hash join partition stream while sibling partitions keep running. In https://github.com/apache/datafusion/issues/21625 (the TPC-H Q18 hang), a `RightSemi` join with an empty build side for some partitions does exactly this. An editor who relies on the wrong reading could reintroduce that hang. ## What changes are included in this PR? One comment-only commit. It updates the doc comments on `PartitionStatus::CanceledUnknown`, `SharedBuildAccumulator::report_canceled_partition`, `BuildReportHandle`, and `BuildReportState::Canceled`. The comments say that a canceled partition is one partition whose stream was dropped early, that other partitions and the query can still be running, and that the partition contributes `true` to the filter because its build keys are unknown. It also replaces one em-dash in an existing comment. ## What is the testing strategy for this PR? The change is comment-only, so it adds no tests. `cargo fmt` and `cargo clippy -p datafusion-physical-plan --all-targets --all-features -- -D warnings` pass. ## Are there any user-facing changes? No. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
