comphead commented on code in PR #7412:
URL: https://github.com/apache/datafusion-comet/pull/7412#discussion_r4470289681
##########
native/core/Cargo.toml:
##########
@@ -84,7 +84,7 @@ parking_lot = "0.12.5"
comet-contrib-delta = { path = "../../contrib/delta/native", optional = true }
# Optional Lance contrib. The native scan implementation lives outside core.
comet-contrib-lance = { path = "../../contrib/lance/native", optional = true }
-reqwest = { version = "0.12", default-features = false, features =
["rustls-tls-native-roots", "http2"] }
+reqwest = { version = "0.13", default-features = false, features =
["rustls-tls-native-roots", "http2"] }
Review Comment:
reqwest 0.13.5 has no `rustls-tls-native-roots` feature. Its `[features]`
table offers `rustls` (rustls-platform-verifier with the `aws-lc-rs` provider)
and `rustls-no-provider` instead, so Cargo rejects this line, which matches the
native CI failures. Choosing between the two, and checking that root
certificates still load the same way for the S3 region lookup in `s3.rs`, needs
a manual PR, so I would close this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
