2010YOUY01 commented on PR #27048: URL: https://github.com/apache/datafusion/pull/27048#issuecomment-6624800665
@alamb THanks for the review! > What I don't understand is the new crate structure and then the need to partially expose some of the existing testing code from the physical expr crate It was intended to keep the PR small, but this make the structure confusing. This is fixed in [dd6f892](https://github.com/apache/datafusion/pull/27048/commits/dd6f892d874447bc38a7f718f5e00484363cef2a): the idea is the fuzzing implementation all lives in `datafusion-fuzz` crate, and since the testing target should be public interface (`SpillPool` in this case), so no extra public API change would be needed, only need to move the fuzzing implementation. RE another major concern for this PR: > why did you make a new crate? Why not just a module in the existing datafusion crate? I think this structure is clearer. Otherwise, integration tests would include regular, extended (slow), and fuzzing tests, making it awkward to maintain or run only a subset of them. Since splitting them doesn't seem to introduce any other issues, I went with the clearer structure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
