alamb commented on code in PR #27048:
URL: https://github.com/apache/datafusion/pull/27048#discussion_r4460497240
##########
.github/workflows/extended.yml:
##########
@@ -82,10 +82,13 @@ jobs:
- name: Show available disk space
run: |
df -h
- - name: Run tests (excluding doctests)
+ - name: Run extended tests
run: cargo xtask ci step test extended
- - name: Run fuzzers with more iterations
+ - name: Run fuzz tests
run: cargo xtask ci step test fuzz
+ # Migrate it to the above unified fuzz runner over time
Review Comment:
Can you please file a ticket that explains the migration plan and has a
checklist of tests to run and link it here? So we have the context in the
future?
##########
datafusion/fuzz/tests/fuzz.rs:
##########
@@ -0,0 +1,63 @@
+// SPDX-License-Identifier: Apache-2.0
+// SPDX-FileCopyrightText: See the NOTICE file distributed with this work for
additional information regarding copyright ownership
+// SPDX-FileContributor: Licensed to the Apache Software Foundation (ASF)
under one or more contributor license agreements
+
+//! One integration entrypoint for DataFusion's registered fuzz suites.
+
+use std::future::Future;
+use std::pin::Pin;
+
+use datafusion_common::Result;
+use test_utils::fuzz::{FuzzTest, RunConfig, run};
+
+mod suites;
+
+/// The single registration point for project-wide fuzz campaigns.
Review Comment:
what is a fuzz campaign? I am not familar with the campaign terminology
##########
test-utils/src/fuzz.rs:
##########
@@ -0,0 +1,187 @@
+// SPDX-License-Identifier: Apache-2.0
+// SPDX-FileCopyrightText: See the NOTICE file distributed with this work for
additional information regarding copyright ownership
+// SPDX-FileContributor: Licensed to the Apache Software Foundation (ASF)
under one or more contributor license agreements
+
+//! Shared execution and replay for [`FuzzTest`] experiments.
+
+use std::future::Future;
+use std::time::Duration;
+
+use datafusion_common::instant::Instant;
+use datafusion_common::{Result, exec_err};
+
+/// A component's fuzz experiment, run by the centralized driver.
Review Comment:
it may help to add a link here to the centralized driver
##########
datafusion/fuzz/Cargo.toml:
##########
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# A private crate providing a single entry point for all fuzz tests.
Review Comment:
why did you make a new crate? Why not just a module in the existing
datafusion crate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
