comphead commented on code in PR #7449:
URL: https://github.com/apache/datafusion-comet/pull/7449#discussion_r4459281981
##########
spark/src/test/scala/org/apache/comet/CometArrayExpressionSuite.scala:
##########
@@ -495,6 +495,24 @@ class CometArrayExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelp
}
}
+ test("folded array literals backed by UnsafeArrayData") {
Review Comment:
`branch-1.1` already has `expressions/array/sequence.sql`, with a Parquet
table `test_sequence`, and `CometSqlFileTestSuite` runs a plain `query` through
`checkSparkAnswerAndOperator`. Could these three queries go there, reading
`i_start` in place of `_2`? That would also match how `main` covers the fix, in
`one_row_relation.sql`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
