Rich-T-kid commented on PR #26816: URL: https://github.com/apache/datafusion/pull/26816#issuecomment-6592374935
> @Rich-T-kid This doesn't look ready for review yet, since the benchmark shows a significant slowdown. Please mark it as ready for review and mention me once it's ready @jayzhan211 this is ready for review. I think your refering to the benchmark run [here](https://github.com/apache/datafusion/pull/26816#issuecomment-6502389785) which comapres main to this branch with `rle_dictionary` enabled. its still slower compared to main because of other perf issues. the benchmark run thats important is the clickbench benchmark run where both sides are `rle_dictionary` enabled [here](https://github.com/apache/datafusion/pull/26816#issuecomment-6479901357). this benchmark shows a large improvement by caching the dictionary hash computation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
