github-actions[bot] commented on PR #26428: URL: https://github.com/apache/datafusion/pull/26428#issuecomment-6569580059
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning 636590bf4f4b4f792d3f2fdacedc5fee0ba54950 Building datafusion v55.1.0 (current) Built [ 41.762s] (current) Parsing datafusion v55.1.0 (current) Parsed [ 0.026s] (current) Building datafusion v55.1.0 (baseline) Built [ 13.689s] (baseline) Parsing datafusion v55.1.0 (baseline) Parsed [ 0.026s] (baseline) Checking datafusion v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.462s] 229 checks: 229 pass, 31 skip Summary no semver update required Finished [ 57.970s] datafusion Building datafusion-physical-plan v55.1.0 (current) Built [ 12.425s] (current) Parsing datafusion-physical-plan v55.1.0 (current) Parsed [ 0.163s] (current) Building datafusion-physical-plan v55.1.0 (baseline) Built [ 9.052s] (baseline) Parsing datafusion-physical-plan v55.1.0 (baseline) Parsed [ 0.168s] (baseline) Checking datafusion-physical-plan v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.510s] 229 checks: 228 pass, 1 fail, 0 warn, 31 skip --- failure method_parameter_count_changed: pub method parameter count changed --- Description: A publicly-visible method now takes a different number of parameters, not counting the receiver (self) parameter. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/method_parameter_count_changed.ron Failed in: datafusion_physical_plan::materialized_cte::MaterializedCteScanExec::with_body_statistics takes 1 parameters in /home/runner/work/datafusion/datafusion/target/semver-checks-shared/semver-checks/git-636590bf4f4b4f792d3f2fdacedc5fee0ba54950/e2a3e96438e593e600b6e79c1af4aa2a321a8c97/datafusion/physical-plan/src/materialized_cte.rs:722, but now takes 2 parameters in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/materialized_cte.rs:787 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 23.517s] datafusion-physical-plan ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
