alamb commented on code in PR #26897:
URL: https://github.com/apache/datafusion/pull/26897#discussion_r4447657263
##########
datafusion/core/tests/parquet/io/bloom_filter_io.rs:
##########
@@ -0,0 +1,85 @@
+// SPDX-License-Identifier: Apache-2.0
+// SPDX-FileCopyrightText: See the NOTICE file distributed with this work for
additional information regarding copyright ownership
+// SPDX-FileContributor: Licensed to the Apache Software Foundation (ASF)
under one or more contributor license agreements
+
+//! Tests tracking storage I/O events during Parquet Bloom filter evaluation.
+
+use std::sync::Arc;
+
+use arrow::array::{ArrayRef, Int32Array, RecordBatch};
+use bytes::Bytes;
+use datafusion::prelude::SessionConfig;
+use insta::assert_snapshot;
+use parquet::arrow::ArrowWriter;
+use parquet::file::properties::{EnabledStatistics, WriterProperties};
+
+use super::ParquetIoTest;
+
+/// Matching row group
+#[tokio::test]
+async fn test_parquet_bloom_filter_io_matching() {
+ let test = bloom_filter_test().await;
+ // Loads the Bloom filters, finds a match, then reads the data pages and
+ // produces a batch.
+ assert_snapshot!(test.query("SELECT * FROM t WHERE a = 10 AND b =
100").await, @r"
+ --- Query: SELECT * FROM t WHERE a = 10 AND b = 100 (1 rows) ---
Review Comment:
I am biased, but quite pleased with this test - it shows clearly the IO
pattern of the reader
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
