ngli-me commented on code in PR #12421:
URL: https://github.com/apache/datafusion/pull/12421#discussion_r1755878706
##########
datafusion/expr-common/src/signature.rs:
##########
@@ -127,7 +129,62 @@ pub enum TypeSignature {
Numeric(usize),
}
-#[derive(Debug, Clone, PartialEq, Eq, Hash)]
+// manual implementation of `PartialOrd`
Review Comment:
Ah, for some reason I thought that derives wouldn't work with an enum with
differing types, but I see it does work with the tests. Added an additional
sanity assertion just to check, and removed the manual implementation for
TypeSignature, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
