alamb commented on code in PR #26854:
URL: https://github.com/apache/datafusion/pull/26854#discussion_r4431446594
##########
datafusion/core/tests/parquet/schema.rs:
##########
@@ -176,6 +176,53 @@ async fn schema_merge_can_preserve_metadata() {
assert_metadata(&actual, &expected_metadata);
}
+/// The extension type is part of the type of a field, so it is kept when the
other
+/// field metadata is cleared.
+#[tokio::test]
+async fn schema_merge_keeps_extension_types_by_default() {
Review Comment:
Yes, please
SLT tests are important so we are testing the end user API to make sure all
the plumbing is connected correctly
This is documented a bit more in
https://datafusion.apache.org/contributor-guide/testing.html#choosing-what-kind-of-test-to-write
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
