sunchao commented on code in PR #7352: URL: https://github.com/apache/datafusion-comet/pull/7352#discussion_r4428976990
########## docs/source/contributor-guide/ci.md: ########## @@ -177,6 +176,38 @@ If you cannot enable Actions on your fork, say so on the pull request. Nothing e tier for you before the queue does, so a maintainer may ask you to reproduce a failure with [`dev/local-ci.sh`](#reproducing-a-suite-failure-locally) first. +### When the fork check finds no run + +When no run of your fork exists for the pull request's head commit, `CI (fork)` says one of two +things: + +- **Enable CI on your fork.** Your fork has no enabled `Comet CI (fork run)` workflow. Usually + GitHub Actions was never enabled on the fork, or no branch that includes the fork workflows has + been pushed to it. GitHub shows this check as failed because it asks you to act. It does not block + merging, but the PR tier has not run on this commit anywhere, so a reviewer has no CI result to Review Comment: A missing fork run establishes only that the mirror found no run on the fork for this SHA. On #7316, commit `cd5dda1c` has both “Enable CI on your fork” and a successful upstream PR-tier Rust job. Could we say that earlier upstream results may still exist? The rollout paragraph below also predicts a failed check for older PRs, but #7326 received the neutral “No fork CI run for this commit” outcome. [#7316 fork check](https://github.com/apache/datafusion-comet/runs/124262617990) · [#7316 upstream test](https://github.com/apache/datafusion-comet/actions/runs/41097900391/job/124220302598) · [#7326 neutral check](https://github.com/apache/datafusion-comet/runs/124262650326) ########## docs/source/contributor-guide/development.md: ########## @@ -648,7 +648,9 @@ changes before retrying; do not switch to `--force` to bypass the check. For a pull request from a fork, the pull request tier of CI runs on your fork's GitHub runners rather than the project's. Enable GitHub Actions on your fork and keep its `main` in sync before you -push; see [Pull requests from forks](ci.md#pull-requests-from-forks). +push; see [Pull requests from forks](ci.md#pull-requests-from-forks). Until you do, the pull +request shows a failed `CI (fork)` check that says **Enable CI on your fork**, and the PR tier Review Comment: Could we qualify this as a fork PR targeting `main`? The mirror filters on `pr.base.ref === 'main'`. Fork PRs targeting a release branch run their PR tier upstream, so contributors to those branches won’t see this check. #7351 is a current example. [Mirror filter](https://github.com/apache/datafusion-comet/blob/c111f7244a1ac69e9d22f410e251e3437525fc9f/.github/workflows/fork_ci_status.yml#L80-L84) · [#7351 upstream run](https://github.com/apache/datafusion-comet/actions/runs/41119076824) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
