alamb commented on code in PR #26867:
URL: https://github.com/apache/datafusion/pull/26867#discussion_r4415096942
##########
datafusion/physical-plan/src/unnest.rs:
##########
@@ -1214,7 +1214,7 @@ impl ListArrayType for FixedSizeListArray {
}
fn value_offsets(&self, row: usize) -> (i64, i64) {
- let start = self.value_offset(row) as i64;
+ let start = self.value_offset_at(row) as i64;
Review Comment:
Due to
- https://github.com/apache/arrow-rs/pull/11070
##########
datafusion/physical-plan/src/spill/mod.rs:
##########
@@ -1985,15 +1985,15 @@ mod tests {
// After appending each batch, spilled_rows and spilled_bytes should
increase incrementally,
// while spill_file_count remains 1 (since we're writing to the same
file)
in_progress_file.append_batch(&batch1)?;
- verify_metrics(&in_progress_file, 1, 440, 3)?;
+ verify_metrics(&in_progress_file, 1, 424, 3)?;
Review Comment:
Due to
- https://github.com/apache/arrow-rs/pull/11694
##########
datafusion/physical-plan/src/spill/spill_pool.rs:
##########
@@ -1005,7 +1005,7 @@ mod tests {
);
assert_eq!(
metrics.spilled_bytes.value(),
- 320,
+ 312,
Review Comment:
Due to
- https://github.com/apache/arrow-rs/pull/11694
##########
datafusion/physical-plan/src/spill/mod.rs:
##########
@@ -2511,21 +2512,39 @@ mod tests {
(0..rows_per_input)
.map(|row| (input * rows_per_input + row) %
dictionary_len),
);
- take(&dictionary, &indices, None)
+ let taken = take(&dictionary, &indices, None)?;
Review Comment:
Due to
- https://github.com/apache/arrow-rs/pull/11281
##########
datafusion/sqllogictest/test_files/datetime/timestamps_timezone.slt:
##########
@@ -1377,33 +1377,27 @@ Timestamp(ns, "+00:00") 2024-07-01T06:00:00Z
##########
## SECTION 16: DST boundaries
##
-## KNOWN WRONG, and the single largest divergence in this file: DataFusion
-## cannot represent an ambiguous or non-existent local time in a named zone at
-## all. Every route into a named zone -- a column cast, `AT TIME ZONE`, a
-## string literal, or `::timestamptz` under a session zone -- fails with an
-## error, where PostgreSQL resolves the value.
-##
-## PostgreSQL's answers, for reference:
+## Casting a naive timestamp into a named zone (a column cast or
+## `AT TIME ZONE`) resolves an ambiguous or non-existent local time the way
+## PostgreSQL does, since https://github.com/apache/arrow-rs/pull/11038:
Review Comment:
Due to
- https://github.com/apache/arrow-rs/pull/11038
##########
datafusion/physical-plan/src/spill/spill_pool.rs:
##########
@@ -1005,7 +1005,7 @@ mod tests {
);
assert_eq!(
metrics.spilled_bytes.value(),
- 320,
+ 312,
Review Comment:
Due to
- https://github.com/apache/arrow-rs/pull/11694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
