timsaucer commented on code in PR #867:
URL: https://github.com/apache/datafusion-python/pull/867#discussion_r1752353650
##########
src/functions.rs:
##########
@@ -676,27 +690,30 @@ pub fn first_value(
}
// nth_value requires a non-expr argument
-#[pyfunction]
-pub fn nth_value(
- expr: PyExpr,
- n: i64,
- distinct: Option<bool>,
- filter: Option<PyExpr>,
- order_by: Option<Vec<PyExpr>>,
- null_treatment: Option<NullTreatment>,
-) -> PyResult<PyExpr> {
- let agg_fn =
datafusion::functions_aggregate::nth_value::nth_value(vec![expr.expr, lit(n)]);
- add_builder_fns_to_aggregate(agg_fn, distinct, filter, order_by,
null_treatment)
-}
+// #[pyfunction]
+// #[pyo3(signature = (expr, n, distinct=None, filter=None, order_by=None,
null_treatment=None))]
+// pub fn nth_value(
+// expr: PyExpr,
+// n: i64,
+// distinct: Option<bool>,
+// filter: Option<PyExpr>,
+// order_by: Option<Vec<PySortExpr>>,
+// null_treatment: Option<NullTreatment>,
+// ) -> PyResult<PyExpr> {
+// // @todo: Commenting this function out for now as it requires some
reworking
Review Comment:
I fixed up `nth_value` in my commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
