emgeee commented on code in PR #867:
URL: https://github.com/apache/datafusion-python/pull/867#discussion_r1752325370
##########
src/dataframe.rs:
##########
@@ -70,13 +70,14 @@ impl PyDataFrame {
if let Ok(key) = key.extract::<PyBackedStr>() {
// df[col]
self.select_columns(vec![key])
- } else if let Ok(tuple) = key.extract::<&PyTuple>() {
- // df[col1, col2, col3]
- let keys = tuple
- .iter()
- .map(|item| item.extract::<PyBackedStr>())
- .collect::<PyResult<Vec<PyBackedStr>>>()?;
- self.select_columns(keys)
+ // } else if let Ok(tuple) = key.extract::<&PyTuple>() {
+ // @todo: make this branch work
Review Comment:
This is one place I may need some help on -- it doesn't look like you can
extract PyTuples anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
