cj-zhukov commented on PR #25299: URL: https://github.com/apache/datafusion/pull/25299#issuecomment-6470972360
@Omega359 thanks for the detailed review - I've addressed all the points (row-order determinism, planning-time rejection of misplaced `array_col`, replace/nullability/multi-column behaviour in `with_column`, and the move to `dataframe/add_column.rs` with the import churn reverted). The PR ready for another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
