asolimando commented on PR #26816: URL: https://github.com/apache/datafusion/pull/26816#issuecomment-6451794818
> [#26816 (comment)](https://github.com/apache/datafusion/pull/26816#issuecomment-6450006894) @asolimando I think I found it 😄 It looks to me that you are working the same angle as @jayzhan211 in https://github.com/apache/datafusion/pull/26703 (Q18/Q33/Q34 ~ 1.8–1.9×, total −28 % vs −29 % here), maybe you two could join forces on this one? I didn't have time to go through all the details of both PRs, but if you check and still have doubts, one quick way to check is to rebase this on #26703 and re-run `clickbench_partitioned`, if the improvements stack (at least partially), then the two PRs don't match exactly, otherwise I suggest to collaborate on this. WDYT? Also, both runs compare against a baseline with `enable_rle_to_dictionary=true`, which is off by default. It would help to also show the branch against the default config, so we know how far dictionary reads still are from plain strings after this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
