asolimando commented on PR #26816: URL: https://github.com/apache/datafusion/pull/26816#issuecomment-6453223610
> > Also, both runs compare against a baseline with enable_rle_to_dictionary=true, which is off by default. It would help to also show the branch against the default config, so we know how far dictionary reads still are from plain strings after this change. > > Yes, this is intentional. Initially, some benchmarks were 5x slower than main, which made it hard to see what was moving the needle in a positive direction when comparing directly against main. > > The end goal is to be faster than main, which uses utf8Views, but there’s still a decent chunk of work to go. So as I iterate, I’m comparing my dictionary encoding optimizations against dictionary encoding on main. Once the benchmark results are closer, I’ll compare against main directly. OK, so this is the "isolate only one variable at the time in benchmarks" angle we discussed offline, that's totally fine, thanks for the clarification! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
