LucaCappelletti94 opened a new pull request, #2744: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2744
`ALTER TABLE t RESET (fillfactor)` fails with `Expected: ADD, RENAME, PARTITION, SWAP, DROP, REPLICA IDENTITY, SET, or SET TBLPROPERTIES after ALTER TABLE, found: RESET`, and a storage parameter named without a value, as in `CREATE VIEW v WITH (security_invoker) AS SELECT 1` or `ALTER TABLE t SET (autovacuum_enabled)`, fails with `Expected: =`. PostgreSQL documents `RESET ( storage_parameter [, ... ] )` for [`ALTER TABLE`](https://www.postgresql.org/docs/current/sql-altertable.html) and reads a [storage parameter](https://www.postgresql.org/docs/current/sql-createtable.html#SQL-CREATETABLE-STORAGE-PARAMETERS) given without a value as `true`. `RESET` parses into a new `AlterTableOperation::ResetOptions` holding the parameter names, the shape #2730 uses for `ALTER VIEW ... RESET`. A key with no `=` after it parses to the existing `SqlOption::Ident` behind a new `Dialect::supports_sql_option_without_value`, which PostgreSQL and Generic enable, so the other dialects still report the missing `=`. PostgreSQL's grammar also accepts a bare key in `CREATE TEXT SEARCH` options, so the negative test there now runs on the dialects without the flag. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
