sdf-jkl opened a new pull request, #26822:
URL: https://github.com/apache/datafusion/pull/26822

   ## Which issue does this PR close?
   
   Closes #21144. Follows #21291.
   
   ## Rationale for this change
   
   Add `arrow.parquet.variant` to DataFusion's canonical extension type 
registry, following the thin wrappers used for JSON and other canonical types.
   
   **Draft: waiting on moving Arrow's `VariantType` from 
`parquet-variant-compute` into `parquet-variant`, and adopting an Arrow release 
containing that move.** The current dependency pulls in the compute and JSON 
crates just to register the extension. Before merging, this PR should depend 
only on `parquet-variant` for that type.
   
   ## What changes are included in this PR?
   
   Add `DFVariant` and its canonical registration. The wrapper retains the 
storage datatype and delegates validation and metadata handling to Arrow's 
`VariantType`. Values use ordinary storage-type formatting.
   
   Arrow's incomplete storage-field validation is tracked separately in 
https://github.com/apache/arrow-rs/issues/11938.
   
   ## What is the testing strategy for this PR?
   
   No new unit tests for the thin delegation wrapper, consistent with the 
unformatted extensions in #21291.
   
   Formatting, strict workspace Clippy (`--all-targets --all-features`), `cargo 
check -p datafusion-common -p datafusion-expr --offline`, and all 1,471 core 
integration tests passed. The required extended workspace run stopped after one 
sort memory-limit failure (154 extended tests passed); that test passed when 
rerun alone. Later workspace test binaries did not run.
   
   ## Are there any user-facing changes?
   
   Yes. The canonical registry recognizes `arrow.parquet.variant`, and 
`DFVariant` is available through `datafusion_common::types`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to