abp002 commented on PR #26723: URL: https://github.com/apache/datafusion/pull/26723#issuecomment-6422925043
@namanjain24-sudo thanks for flagging it. The identical lines come from `main`, not from either PR: both branches predate #25273 and #26551, so a diff against current `main` shows those two commits reverted in both. Against the merge base, which is what GitHub shows, #26608 and this PR don't share any lines. They do touch the same part of `build_join`, so whichever lands second needs a rebase. If this one goes first, I'll rebase #26608 on top of it. The only place they meet is the skip for aggregates that are NULL on empty input (the caveat @jayzhan211 mentions above): #26608 stops skipping the compensation when a `HAVING` was pulled up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
