namanjain24-sudo commented on issue #25208: URL: https://github.com/apache/datafusion/issues/25208#issuecomment-6402474029
Honestly: nothing of mine broke. @alexandrefimov filed this from a Substrait conformance suite and I picked it up off the issue list. The concrete gap is that the column we emit for a multi-set aggregate doesn't match what the spec says it holds, so a plan DataFusion produces is read differently by a consumer that follows the spec. I have not hit that in a real workload myself. If that isn't worth the complexity, I am happy to close the PR and leave it to you and @alexandrefimov to decide whether the issue is worth doing at all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
