tlm365 commented on code in PR #12168: URL: https://github.com/apache/datafusion/pull/12168#discussion_r1747837674
########## datafusion/functions/Cargo.toml: ########## @@ -52,9 +52,9 @@ encoding_expressions = ["base64", "hex"] # enable math functions math_expressions = [] # enable regular expressions -regex_expressions = ["regex"] +regex_expressions = ["regex", "string_expressions"] Review Comment: @alamb thanks for reviewing 🙏 > Perhaps it would be beter placed somewhere in functions/src/ oh, I agree, will update it soon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
