patrickswedish commented on PR #26006: URL: https://github.com/apache/datafusion/pull/26006#issuecomment-6399803409
Thank you @jayzhan211 for the thorough review, approval, and the sharp catch on `compare_join_arrays`! You are completely right — constructing `JoinKeyComparator` over the entire array buffers incurred an unnecessary O(N) scan (`normalize_float_zero` and dictionary key inspection) for what should be a constant-time single-row comparison. Slicing both sides to single-row views (`a.slice(..., 1)`) preserves strictly O(1) execution per call without full-array normalization overhead. Applied your exact suggestion in [`154624c`](https://github.com/apache/datafusion/pull/26006/commits/154624c4129a6bceb5d58eb305c12f8446e041fe). All checks and tests passing cleanly and ready for merge! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
