TinyMurky commented on issue #25546: URL: https://github.com/apache/datafusion/issues/25546#issuecomment-6394252626
Hello @jayzhan211! Sorry for the late, I have finished the first version PR, could you review this PR? In this PR I introduced an API change, which I added `null_aware` to `SortMergeJoinExec` https://github.com/apache/datafusion/blob/7798c94d6f506e237ef233f641a1c1a74ece9bc7/datafusion/proto-models/proto/datafusion.proto#L1829-L1839 The reason behind it is that I was trying to add `null_aware` to `SortMergeJoinExec::try_new`，which imitating the interface of `HashJoinExec::try_new`. https://github.com/apache/datafusion/blob/7798c94d6f506e237ef233f641a1c1a74ece9bc7/datafusion/physical-plan/src/joins/sort_merge_join/exec.rs#L211-L227 However, the api change mention above trigger the following warning from [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks), the full warning message can be found in [here](https://github.com/apache/datafusion/pull/26090#issuecomment-6393008954) ``` Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). ``` How should I address this warning? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
