Blizzara commented on code in PR #12225:
URL: https://github.com/apache/datafusion/pull/12225#discussion_r1747658283
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -412,6 +428,10 @@ pub async fn from_substrait_rel(
);
let mut names: HashSet<String> = HashSet::new();
let mut exprs: Vec<Expr> = vec![];
+ input.schema().iter().for_each(|(qualifier, field)| {
+ exprs.push(col(Column::from((qualifier, field))))
+ });
Review Comment:
this seems like the right thing - but then to get tests passing again I
think we'll also need to add support for the `remap`
https://substrait.io/relations/basics/#emit-output-ordering, both here and in
producer...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
