jayzhan211 commented on PR #26563: URL: https://github.com/apache/datafusion/pull/26563#issuecomment-6383993503
Closing this. It changes no behavior, and the duplicated memory rules it merges turned out to be consistent across the streams, so it doesn't fix or prevent anything on its own. The recent bugs here (#26575, #26701) are in each stream's own reaction to a refused reservation, which this PR deliberately leaves per stream. The tests from #26562 now catch the breakages this refactor was meant to guard against. If a later change needs to touch these rules in every stream, I'm happy to reopen this or reuse the branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
