alamb commented on PR #12044:
URL: https://github.com/apache/datafusion/pull/12044#issuecomment-2331481739
Sorry -- here are the results of my benchmark run -- TLDR is this looks
great to me
```
++ critcmp main stringview-output-for-substr
group
main stringview-output-for-substr
-----
---- ----------------------------
LONGER THAN 12/substr_large_string [size=1024, count=64, strlen=128]
1.01 147.7±0.16µs ? ?/sec 1.00 146.4±0.10µs ? ?/sec
LONGER THAN 12/substr_large_string [size=4096, count=64, strlen=128]
1.00 590.8±0.14µs ? ?/sec 1.00 589.1±1.54µs ? ?/sec
LONGER THAN 12/substr_string [size=1024, count=64, strlen=128]
1.05 154.9±0.25µs ? ?/sec 1.00 148.0±0.11µs ? ?/sec
LONGER THAN 12/substr_string [size=4096, count=64, strlen=128]
1.08 636.7±0.81µs ? ?/sec 1.00 591.5±0.27µs ? ?/sec
LONGER THAN 12/substr_string_view [size=1024, count=64, strlen=128]
1.50 158.2±0.20µs ? ?/sec 1.00 105.4±0.04µs ? ?/sec
LONGER THAN 12/substr_string_view [size=4096, count=64, strlen=128]
1.50 629.0±0.18µs ? ?/sec 1.00 420.6±0.12µs ? ?/sec
SHORTER THAN 12/substr_large_string [size=1024, strlen=12]
1.00 56.8±0.02µs ? ?/sec 1.03 58.3±0.93µs ? ?/sec
SHORTER THAN 12/substr_large_string [size=4096, strlen=12]
1.00 223.8±0.30µs ? ?/sec 1.02 227.3±0.05µs ? ?/sec
SHORTER THAN 12/substr_string [size=1024, strlen=12]
1.05 89.3±0.05µs ? ?/sec 1.00 84.9±0.04µs ? ?/sec
SHORTER THAN 12/substr_string [size=4096, strlen=12]
1.05 351.7±0.32µs ? ?/sec 1.00 335.2±0.10µs ? ?/sec
SHORTER THAN 12/substr_string_view [size=1024, strlen=12]
2.82 58.4±0.04µs ? ?/sec 1.00 20.7±0.01µs ? ?/sec
SHORTER THAN 12/substr_string_view [size=4096, strlen=12]
2.79 227.8±0.05µs ? ?/sec 1.00 81.6±0.04µs ? ?/sec
SRC_LEN > 12, SUB_LEN < 12/substr_large_string [size=1024, count=6,
strlen=128] 1.00 40.9±0.01µs ? ?/sec 1.00 41.1±0.03µs
? ?/sec
SRC_LEN > 12, SUB_LEN < 12/substr_large_string [size=4096, count=6,
strlen=128] 1.01 157.6±0.13µs ? ?/sec 1.00 156.3±0.13µs
? ?/sec
SRC_LEN > 12, SUB_LEN < 12/substr_string [size=1024, count=6, strlen=128]
1.06 43.9±0.11µs ? ?/sec 1.00 41.5±0.08µs ? ?/sec
SRC_LEN > 12, SUB_LEN < 12/substr_string [size=4096, count=6, strlen=128]
1.07 169.7±0.03µs ? ?/sec 1.00 158.4±0.09µs ? ?/sec
SRC_LEN > 12, SUB_LEN < 12/substr_string_view [size=1024, count=6,
strlen=128] 1.74 43.7±0.01µs ? ?/sec 1.00 25.1±0.04µs
? ?/sec
SRC_LEN > 12, SUB_LEN < 12/substr_string_view [size=4096, count=6,
strlen=128] 1.69 166.4±0.07µs ? ?/sec 1.00 98.6±0.06µs
? ?/sec
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
