shrivasshankar commented on PR #25790: URL: https://github.com/apache/datafusion/pull/25790#issuecomment-6345422444
> @shrivasshankar, > > Thanks for the follow-up changes. The Decimal filter selectivity improvements now have appropriate correctness safeguards and regression coverage. The approach looks good. > > Keeping Decimal arithmetic outside interval-based statistics estimation is the right architectural boundary for now. Arithmetic can change precision and scale, so propagating constraints without accounting for those type changes could produce incorrect column bounds. Retaining the default selectivity for unsupported expressions while allowing safe Decimal comparisons, widening casts, and negation is a sound approach. > > The previous correctness blocker is addressed, and the additional tests cover the requested arithmetic fallback, mixed-scale coercion, and end-to-end SQL behavior. I found no remaining actionable issues. Approved. Thanks for the review @kosiew! Updated the branch with main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
