kazuyukitanimura commented on code in PR #7026:
URL: https://github.com/apache/datafusion-comet/pull/7026#discussion_r4339659503
##########
spark/src/main/scala/org/apache/comet/objectstore/NativeConfig.scala:
##########
@@ -428,6 +444,12 @@ object NativeConfig {
"Native scan does not support ABFS files from more than one
container or account " +
s"(${first.getRawAuthority} and ${uri.getRawAuthority})")
}
+ collectS3(uri)
+ }
+ val s3Reason =
+ if (s3Uris.isEmpty) None else S3ConfigGate.declineReason(hadoopConf,
s3Uris.values.toSeq)
Review Comment:
On a bucket that uses the Comet credential-provider SPI, native never reads
its own credential chain. The gate no longer compares access.key, secret.key,
session.token, aws.credentials.provider or the assumed.role.* keys there. It
does not skip them when Hadoop resolves credentials through a keystore or with
clear-text-fallback=false, because the built-in adapter can't see either.
Store-level keys (endpoint, region, path-style, requester-pays) are still
compared. The new tests cover the adapter with long-form aliases and the three
cases that still decline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
