kosiew commented on code in PR #25962:
URL: https://github.com/apache/datafusion/pull/25962#discussion_r4335503755
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -1162,6 +1151,129 @@ impl AggregateExec {
Some(Transformed::yes(self))
}
+ /// Combine adjacent partial and final aggregates in the given plan if
they are
Review Comment:
Could we mention here that this helper should run after distribution
enforcement, normally `EnsureRequirements`? It checks expression compatibility
but not distribution requirements. A documentation note would clarify the
contract without adding a runtime check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
