tschwarzinger commented on code in PR #21714:
URL: https://github.com/apache/datafusion/pull/21714#discussion_r4313259871
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -275,23 +274,14 @@ impl LogicalPlanBuilder {
let n_cols = values[0].len();
let mut fields = ValuesFields::new();
for j in 0..n_cols {
- let field_type = schema.field(j).data_type();
Review Comment:
@cyberbeam524 I am also unsure whether just taking the result field metadata
is the best approach here.
I think this is also something that warrants discussion outside of this
issue. But I think this is required for getting the tests to run. Maybe
`arrow_cast` is the best way after all to get this running and avoid changing
the semantics of `VALUES` for now. Then let us discuss this in a follow-up.
But I think @paleolimbot has a better sense of whether this change should
stay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
