alamb commented on code in PR #25591: URL: https://github.com/apache/datafusion/pull/25591#discussion_r4312781320
########## docs/source/contributor-guide/index.md: ########## @@ -239,3 +239,25 @@ According to Runs-On, spot instance termination is extremely rare for instances ### GitHub Runners We also use standard GitHub runners for some actions in the main repository; these are also runnable in forks. + +#### Pull Requests from Forks + +A pull request from a fork to `main` runs the Rust workflow on your fork, with Review Comment: it may be worth mentioning here the rationale for this behavior -- namely that CI requires substantial worker time and we have been one of the largest Apache queue users and reference a ticket ########## docs/source/contributor-guide/index.md: ########## @@ -239,3 +239,25 @@ According to Runs-On, spot instance termination is extremely rare for instances ### GitHub Runners We also use standard GitHub runners for some actions in the main repository; these are also runnable in forks. + +#### Pull Requests from Forks + +A pull request from a fork to `main` runs the Rust workflow on your fork, with +your own GitHub Actions runners. The main repository runs only the fast lint jobs for +such a pull request and adds a `Rust (fork)` check that links to the run on +your fork. The merge queue runs the full workflow on the merged result before +a pull request merges, so a green fork run does not replace it. + +To make this work: + +1. Enable workflows on your fork. Open the **Actions** tab of your fork and + confirm the prompt. If the `Rust (fork)` check reports no fork run for a + commit that changed code, this step is missing; enable workflows and push + again. A push that changes only documentation or Markdown does not start Review Comment: > A push that changes only documentation or Markdown does not start > the Rust workflow; the check then reports that no fork run exists for the > commit, and the merge queue still runs the full workflow. That seems like it describes an implementation detail and could probably be removed to make this paragraph easier to read -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
