jayzhan211 commented on code in PR #12296:
URL: https://github.com/apache/datafusion/pull/12296#discussion_r1742190471
##########
datafusion/expr/src/udaf.rs:
##########
@@ -262,6 +262,19 @@ impl AggregateUDF {
self.inner.is_descending()
}
+ /// Returns true if the function is min. Used by the optimizer
+ pub fn is_min(&self) -> bool {
Review Comment:
If there is really no "general context", I think it is fine to just leave
them as it is. Having specific function name matching in Impl Trait doesn't
make sense to me 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
