tlm365 commented on code in PR #12284: URL: https://github.com/apache/datafusion/pull/12284#discussion_r1741012425
########## datafusion/sqllogictest/test_files/aggregate.slt: ########## @@ -5863,3 +5863,32 @@ ORDER BY k; ---- 1 1.8125 6.8007813 Float16 Float16 2 8.5 8.5 Float16 Float16 + + +# test max_by function Review Comment: Could you please update docs for the new function [here](https://github.com/apache/datafusion/blob/main/docs/source/user-guide/sql/aggregate_functions.md?plain=1). I think it would be better if we describe in more detail that `min_by/max_by` is an "order-sensitive" function OR at least provide some examples of that behavior (for the `max_by(a, b)` scenario where multiple values of `a` have the same maximum value of `b`). Additionally, update unit tests for these scenarios as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
