s5dsn-eqee opened a new issue, #2650:
URL: https://github.com/apache/datafusion-sqlparser-rs/issues/2650
Part of #2591, scoped to the parser only.
#2591 agreed on a series of pure-move PRs but did not fix the target layout.
#944 and #1581 both went per-statement (~35 files, one per top-level keyword).
#1581 stalled as one large
PR, and its author noted that shared helpers ended up placed arbitrarily.
## Proposed layout
A flat layout mirroring `src/ast/`, so a struct in `ast/ddl.rs` is parsed in
`parser/ddl.rs`:
```text
src/parser/
mod.rs Parser struct, token cursor, errors, identifiers, lists,
statement dispatch
expr.rs precedence climbing, prefix/infix, function calls, literals
query.rs SELECT, set ops, CTEs, FROM/joins, windows
data_type.rs
ddl.rs CREATE TABLE, columns, constraints, DROP (existing
create.rs, alter.rs stay beside)
dml.rs INSERT / UPDATE / DELETE (existing
merge.rs stays beside)
dcl.rs GRANT / REVOKE / roles / policies
statement.rs SHOW / SET / DECLARE / transactions / EXPLAIN / misc
```
## Order
Smallest conflict surface first:
- [ ] dcl
- [ ] dml
- [ ] data_type
- [ ] statement
- [ ] ddl
- [ ] query
- [ ] expr
@alamb @LucaCappelletti94 wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
