Jefffrey commented on code in PR #26248:
URL: https://github.com/apache/datafusion/pull/26248#discussion_r4267916127
##########
datafusion/functions-aggregate/src/min_max.rs:
##########
@@ -59,6 +59,9 @@ fn get_min_max_result_type(input_types: &[DataType]) ->
Result<Vec<DataType>> {
// TODO add checker, if the value type is complex data type
Ok(vec![dict_value_type.deref().clone()])
}
+ DataType::RunEndEncoded(_, values) => {
+ get_min_max_result_type(&[values.data_type().clone()])
Review Comment:
worth filing a followup ticket to see if we should align these two (dict and
ree)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]