alamb commented on code in PR #26215:
URL: https://github.com/apache/datafusion/pull/26215#discussion_r4251067778
##########
datafusion/physical-plan/src/sorts/cursor.rs:
##########
@@ -643,6 +649,11 @@ impl<T: CursorValues> CursorValues for ArrayValues<T> {
#[inline(always)]
fn eq(l: &Self, l_idx: usize, r: &Self, r_idx: usize) -> bool {
+ // Fast path: neither array has nulls, so the match below would take
+ // the (false, false) arm every time.
+ if !l.has_nulls && !r.has_nulls {
Review Comment:
this still basically dynamically dispatches each row
I wonder if there is some way to parameterize ArrayValues so we could
dispatch just once 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
