jayzhan211 commented on code in PR #12274:
URL: https://github.com/apache/datafusion/pull/12274#discussion_r1740103883
##########
datafusion/core/tests/dataframe/dataframe_functions.rs:
##########
@@ -346,7 +346,7 @@ async fn test_fn_approx_median() -> Result<()> {
"+-----------------------+",
"| approx_median(test.b) |",
"+-----------------------+",
- "| 10 |",
+ "| 10.0 |",
Review Comment:
Yes, I change the result to f64 now.
I think it is fine to have f64 for median value. I check the result of
Duckdb, they have double for integer, although they have decimal for decimal
input, but since we doesn't support decimal for approx_median so there is no
regression. We could support decimal case later on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
