jayzhan211 opened a new pull request, #12269:
URL: https://github.com/apache/datafusion/pull/12269
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
To avoid Row converter in multi group by clause, we add equality check for
group values Array.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
## Benchmark
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query ┃ main ┃ row-group ┃ Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0 │ 0.40ms │ 0.48ms │ 1.19x slower │
│ QQuery 1 │ 43.92ms │ 46.27ms │ 1.05x slower │
│ QQuery 2 │ 76.59ms │ 76.90ms │ no change │
│ QQuery 3 │ 63.93ms │ 67.31ms │ 1.05x slower │
│ QQuery 4 │ 447.49ms │ 426.92ms │ no change │
│ QQuery 5 │ 704.75ms │ 680.61ms │ no change │
│ QQuery 6 │ 36.18ms │ 35.58ms │ no change │
│ QQuery 7 │ 37.50ms │ 36.56ms │ no change │
│ QQuery 8 │ 687.91ms │ 599.47ms │ +1.15x faster │
│ QQuery 9 │ 654.23ms │ 615.37ms │ +1.06x faster │
│ QQuery 10 │ 204.86ms │ 175.98ms │ +1.16x faster │
│ QQuery 11 │ 237.91ms │ 195.13ms │ +1.22x faster │
│ QQuery 12 │ 758.26ms │ 695.74ms │ +1.09x faster │
│ QQuery 13 │ 1011.35ms │ 885.85ms │ +1.14x faster │
│ QQuery 14 │ 980.44ms │ 883.32ms │ +1.11x faster │
│ QQuery 15 │ 544.60ms │ 468.27ms │ +1.16x faster │
│ QQuery 16 │ 1751.52ms │ 1318.86ms │ +1.33x faster │
│ QQuery 17 │ 1530.76ms │ 1311.78ms │ +1.17x faster │
│ QQuery 18 │ 3702.09ms │ 4322.81ms │ 1.17x slower │
│ QQuery 19 │ 53.09ms │ 52.30ms │ no change │
│ QQuery 20 │ 1535.97ms │ 1475.38ms │ no change │
│ QQuery 21 │ 1830.57ms │ 1747.03ms │ no change │
│ QQuery 22 │ 4105.92ms │ 3851.14ms │ +1.07x faster │
│ QQuery 23 │ 8317.37ms │ 8089.16ms │ no change │
│ QQuery 24 │ 498.14ms │ 479.31ms │ no change │
│ QQuery 25 │ 506.65ms │ 491.19ms │ no change │
│ QQuery 26 │ 571.42ms │ 544.09ms │ no change │
│ QQuery 27 │ 1323.25ms │ 1325.59ms │ no change │
│ QQuery 28 │ 10284.17ms │ 10243.26ms │ no change │
│ QQuery 29 │ 404.45ms │ 441.24ms │ 1.09x slower │
│ QQuery 30 │ 837.55ms │ 847.60ms │ no change │
│ QQuery 31 │ 829.55ms │ 779.72ms │ +1.06x faster │
│ QQuery 32 │ 4698.41ms │ 3555.64ms │ +1.32x faster │
│ QQuery 33 │ 4180.51ms │ 4229.86ms │ no change │
│ QQuery 34 │ 4055.17ms │ 3981.71ms │ no change │
│ QQuery 35 │ 1015.82ms │ 1195.95ms │ 1.18x slower │
│ QQuery 36 │ 143.36ms │ 154.85ms │ 1.08x slower │
│ QQuery 37 │ 99.73ms │ 105.03ms │ 1.05x slower │
└──────────────┴────────────┴────────────┴───────────────┘
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
