dwsmith1983 commented on PR #6384: URL: https://github.com/apache/datafusion-comet/pull/6384#issuecomment-6051195838
> Could we add it as a test next to the chained ones, with a check that the join really became a `CometHashJoinExec`? Added in 60730d808, after the kept-join tests: your window query with `maxBuildSize=-1` and broadcasts off, run with AQE on and off. It checks the answer against Spark and that the plan has both a `CometHashJoinExec` and a `CometWindowExec`, so the window runs natively over the rewritten join. With `restoreRequiredOrdering` disabled it fails with the native `All partition by columns should have an ordering` assertion. The description now says `Closes #6673`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
