rexminnis commented on PR #2485: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2485#issuecomment-6036899136
Thanks — that's fair, and I appreciate you saying it plainly. I use this library in a product that sits in front of Trino, so the dialect matters to me enough to do this properly rather than quickly. Since your comment I've: removed the table-versioning hook (it was accepting syntax Trino rejects); run every statement in the test file through a real Trino and recorded its verdict next to each; added a rejected form for every enabled feature; listed the parser-wide leniencies Trino doesn't share instead of leaving them to be found; stripped the comments that restated the code; and built a mutation fuzzer against Trino whose output the ignored `differential_verdicts_from_file` test checks — 1,100 mutants; it found one real gap (Trino allows aliases this parser reserved), which is fixed, and what remains is listed in the test file as known misses rather than left to be found. The description is rewritten. No rush, and no need for you to pick it up yourself — I understand the review budget. If @alamb or anyone else has time, it should now be reviewable without knowing Trino in detail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
