LucaCappelletti94 commented on PR #2485: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2485#issuecomment-6035636341
Hi @rexminnis. I help maintain this project as a volunteer in my free time and I'm not paid for it. With 70+ open PRs, I spend my time on the ones I can actually review and that matter to my own work, i.e. PRs on dialects I use or dialects derived from those, where I know enough to judge what's right or wrong. I'm not familiar with Trino, so I can't give a new dialect the detailed review it needs. Furthermore, this PR reads to me as largely LLM-generated without enough human review, which makes it require more scrutiny, not less. I'm currently focusing on bug fixes, which need attention more urgently. Other reviewers, such as @alamb, which I have already pinged about this matter, are welcome to pick this up. What would help any reviewer: - Rewrite the PR description in your own words. - Remove comments and documentation that don't add information. - Only enable features that are tested, and confirm each one against Trino's actual behavior. - Add tests for syntax Trino rejects, not only syntax it accepts. - **If a reference Trino lexer/parser exists, a differential fuzzing harness plus seed corpus additions would be strong evidence of correctness.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
