bvolpato commented on PR #23469: URL: https://github.com/apache/datafusion/pull/23469#issuecomment-6032367281
thanks for the review, Neil. agreed, the fix is about conditionless joins more broadly. I updated the title and description accordingly. I added SQL tests for outer joins and uncorrelated EXISTS / NOT EXISTS, including empty inputs. They're also run in optimized Substrait round-trip mode in CI, so they exercise the join shapes created by the optimizer. Removing the producer fix makes seven of the new cases fail with `join condition should not be empty`; they pass with the fix restored. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
