comphead commented on code in PR #553:
URL: https://github.com/apache/datafusion-comet/pull/553#discussion_r1736610770
##########
native/core/src/execution/datafusion/expressions/sum_decimal.rs:
##########
@@ -112,6 +112,13 @@ impl AggregateExpr for SumDecimal {
self.scale,
)))
}
+
+ fn default_value(&self, _data_type: &DataType) -> DFResult<ScalarValue> {
Review Comment:
correct, that was my suggestion to use the same alias across expression
files, it can Result or DFResult, whatever is easier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
