mohitgurav20 commented on PR #25719: URL: https://github.com/apache/datafusion/pull/25719#issuecomment-5998560386
Thanks for the review @asolimando! Addressed all your comments: - **Integration tests**: Replaced the CAST unit test with `FilterExec`/`StatisticsExec` tests that actually exercise the fallback path when interval analysis is unsupported (e.g., Utf8 equality yielding `1 / NDV`), along with a test covering the CAST boundary behavior. - **Test rename**: Renamed `test_fallback_selectivity_no_conjuncts_returns_default` to `test_fallback_selectivity_non_equality_returns_default`. - **Comment fixes**: Updated the comment on `test_fallback_selectivity_multiple_unhandled_conjuncts` to match the `<>` operators used, and removed the historical reference to the old fallback path in `compute_fallback_selectivity`. All tests are passing locally and formatted. Ready for another look when you have a moment! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
