2010YOUY01 commented on code in PR #24510: URL: https://github.com/apache/datafusion/pull/24510#discussion_r4175659983
########## docs/source/contributor-guide/index.md: ########## @@ -129,6 +134,87 @@ Please ensure your PR follows the [testing guide](testing.md). In particular: [Choosing What Kind of Test to Write](testing.md#choosing-what-kind-of-test-to-write). - Run any relevant commands from the [testing quick start](testing.md#testing-quick-start). +## AI-Assisted contributions + +DataFusion has the following policy for AI-assisted PRs: + +- We welcome AI-assisted PRs from anyone. We do not welcome unreviewed "AI dumps" (defined below). +- The PR author should have personally read the entire PR they submit, and **understand the core ideas** behind the implementation **end-to-end**. Authors should be ready to justify and help reviewers understand the design and code during review. Review Comment: > I might push back on this point as its a bit vague to enforce; I agree this might not convey the idea clearly. I think we can agree that a PR should be opened with sufficient understanding, but “understanding” itself is still a bit vague. In practice, I see quite a few PRs where the contributor's understanding isn't deep enough when the PR is opened. That makes review much harder, and sometimes the review still effectively turns into the reviewer driving the AI through the contributor. I'm not sure what the best way is to define the bar for “enough understanding/confidence to open a PR.” “Being able to reimplement it manually” seems like one concrete test for that bar, rather than the principle itself. And I agree edge cases finding should be excluded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
