dwsmith1983 commented on PR #5872: URL: https://github.com/apache/datafusion-comet/pull/5872#issuecomment-5972462420
> Could you move it into a new "Upgrading to Comet 1.2.0" section and say that 1.1.0 and earlier addressed these endpoints path-style? Moved in c5594463b. The entry also covers the no-endpoint case with your `fs.s3a.endpoint.region=us-east-1` example in both directions, notes that host-matching proxy or egress rules will see the new hosts, and says native Parquet and CSV scans, since native Iceberg reads go through iceberg-rust's FileIO and are unchanged. The description has the same case. > Could you move the new block above the `extractObjectStoreOptions` scaladoc? That block is gone in aa73a0d6c: Hadoop's profile provider now resolves through `HadoopS3ACredentialProviderAdapter` on the executor, so the JVM no longer forwards a default credentials path and `NativeConfig.scala` is back to main. > If we keep these, could this row say so? Neither is kept. Hadoop's provider picks the STS region and endpoint now, so the row describes the routing instead, and the S3 credential provider guide covers the class-loader requirement, the explicit class and the blank opt-out. The AWS SDK `ProfileCredentialsProvider` names still resolve natively as on main; their differences from Hadoop are tracked in #6575. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
