zhuqi-lucas commented on PR #25688: URL: https://github.com/apache/datafusion/pull/25688#issuecomment-5965273828
Thanks @2010YOUY01, your summary is accurate. I like the extensible boundaries idea. The analyzer/optimizer split is the first such boundary, and a generic "boundary + validator" entry in the rule list can build on it rather than replace it. I would treat this PR as the starting point and do the general mechanism as a follow-up, there is a lot we can build on top of it. The validation part is cheap: behind `cfg(debug_assertions)`, run the sanity check (distribution and ordering satisfied) after every optimizer rule, so a violation points at the rule that caused it. Zero cost in release, same as the existing per-rule `check_invariants`. Happy to add that here if you both prefer, otherwise as a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
