2010YOUY01 commented on PR #25390: URL: https://github.com/apache/datafusion/pull/25390#issuecomment-5964391852
> @2010YOUY01 Thanks for the quick review. I was hoping this addition to the LimitedDistinctAggregation rule would be small enough to keep the complexity low. The only counter I have to the handwritten example would be queries that are generated from dashboards. Even then I don't know how common this shape would be. Please confirm you would like to avoid this addition to the codebase, and I'll close the PR. I think we could close it now, but if later someone told us this query shape is common, let's resume it then. Thanks again. > I'd appreciate if you could also point me to an area of the project where contributions would be most valuable right now. Just looking to contribute more to DF. The rule I personally follow is to implement features and optimizations that solves your problem, while keeping the overall complexity of the codebase lower. New features and improvements are obviously important, but I believe DataFusion is increasingly bottlenecked by internal implementation complexity. So adding functionality while also removing complexity is becoming even more valuable — and also more challenging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
