andygrove commented on PR #4565: URL: https://github.com/apache/datafusion-comet/pull/4565#issuecomment-5960108530
Merged main and pushed fixes for the review feedback; the inline threads have the details. From the review summary: `lazy val modes` now says why it is lazy, the duplicated `createExec` comment is gone, and both test gaps are covered, the shuffle gate by `sort_aggregate_without_comet_shuffle.sql` and the output ordering by the new cache and native planner tests. Because the serde, the planner, the native planner and all five Spark diffs changed, I added `run-spark-4.1-tests` and `run-spark-3.4-tests`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
